D16852: Add Documents to the default list of Places

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: elvisangelaccio.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh, this doesn't actually have any effect on the test since the item is only created conditionally, and the testing environment's homedir doesn't create the XDG dirs by default. So the tests still pass, whoo. Though it isn't actually being tested, but that's also happening for the other conditional XDG items. Not your fault, and that should be fixed elsewhere.
  
  This does make Dolphin's `placesitemmodeltest` fail though, since it's smarter and by adding a new item the expected counts are now all off. Since apps have been branched, that could be fixed on master without the need for ifdefs.
  
  Though I'm accepting this now, please wait for approval from some other people too, like @elvisangelaccio.

REPOSITORY
  R241 KIO

BRANCH
  add-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16852

To: acrouthamel, #frameworks, #dolphin, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, ngraham, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181113/9f44c650/attachment.htm>