D16767: Add option to toggle all hidden panel item to view menu

Elvis Angelaccio noreply at phabricator.kde.org
Sun Nov 11 18:38:55 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> placespanel.h:53
> +    void showHiddenEntriesChanged(bool shown);
> +    void hiddenListChanged(bool empty);
>  

This signal is a bit confusing. I'd prefer using:

  void hiddenCountChanged(int hiddenCount);

since it's how you are actually using it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16767

To: rizzitello, #dolphin, #vdg, elvisangelaccio, ngraham
Cc: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181111/3475a331/attachment.htm>


More information about the kfm-devel mailing list