D16824: [PlacesPanel] Port to KFilePlaceEditDialog

Elvis Angelaccio noreply at phabricator.kde.org
Sun Nov 11 18:14:10 GMT 2018


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  This patch ports away from the old PlacesItemEditDialog copy,
  which doesn't honour the "applicationLocal" checkbox.
  
  KFilePlaceEditDialog was not exported by KIO, but it will be starting
  from 5.53
  
  BUG: 376619
  FIXED-IN: 19.03.80

TEST PLAN
  - Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox
  - Edit an existing (global) place and check the "only show in dolphin" checkbox

REPOSITORY
  R318 Dolphin

BRANCH
  kfileplaceeditdialog-port (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16824

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/panels/places/placesitemeditdialog.cpp
  src/panels/places/placesitemeditdialog.h
  src/panels/places/placespanel.cpp

To: elvisangelaccio, #dolphin
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181111/71effff4/attachment.htm>


More information about the kfm-devel mailing list