D16767: Add option to toggle all hidden panel item to view menu

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinmainwindow.cpp:1351
> +    connect(m_placesPanel, &PlacesPanel::hiddenListChanged, this, [actionShowAllPlaces](bool show){
> +        actionShowAllPlaces->setVisible(show);
> +    });

We don't make menu items conditionally disappear. Please only disable it when it can't be used, don't hide it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16767

To: rizzitello, #dolphin, #vdg, elvisangelaccio, ngraham
Cc: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181111/b4c48e41/attachment.htm>