D16767: Add option to toggle all hidden panel item to view menu

Elvis Angelaccio noreply at phabricator.kde.org
Sun Nov 11 11:45:11 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> placespanel.cpp:291
>      QAction* showAllAction = nullptr;
>      if (m_model->hiddenCount() > 0) {
> -        showAllAction = menu.addAction(QIcon::fromTheme(QStringLiteral("visibility")), i18nc("@item:inmenu", "Show All Entries"));

One more thing: the new action needs to be added only if we have hidden entries, like we do here. This means we need one more public method in `PlacesPanel`

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16767

To: rizzitello, #dolphin, #vdg, elvisangelaccio
Cc: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181111/becb7632/attachment.htm>


More information about the kfm-devel mailing list