D16767: Add option to toggle all hidden panel item to view menu

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Makes sense, thanks

INLINE COMMENTS

> placespanel.cpp:67
>  {
> +    m_showAllAction = new QAction(QIcon::fromTheme(QStringLiteral("hint")), i18nc("@item:inmenu", "Hidden Places"));
> +    m_showAllAction->setCheckable(true);

Why drop "Show" from the label though?

> placespanel.h:45
>      void proceedWithTearDown();
> +    QAction* actionShowAllPlaces();
>  

Please create the action/checkbox in `DolphinMainWindow` and just add a public slot here in the panel.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D16767

To: rizzitello, #dolphin, #vdg, elvisangelaccio
Cc: elvisangelaccio, veqz, davidc, ngraham, kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181108/345bb582/attachment.htm>