D16648: Open externally called files/directories in new tabs

[Alexander Saoutkin]

feverfew created this revision.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  BUG: 183429
  
  Added option allowing user to choose if they would want to open 
  externally called files/directories in new tabs. This option is enabled by default.
  
  When this option is selected externally called files/directories are opened in a a new tab of an instance of Dolphin that already exists. If there is no instance then the files/directories are opened in a new window. The newly opened file/directory has its tab activated, and consequently, the window is also activated.
  
  When the user clicks "Open In New Window" or "Detach Tab", the files/directories are opened in a new window, regardless of the setting chosen.

TEST PLAN
  [Manual]
  Before testing, set the default file manager as the newly built Dolphin executable.
  Please note that when testing the "Open In New Window"/"Detach Tab" feature, an old instance of dolphin will be opened (in particular, the executable in your /usr/ directory), to properly test please change the source code to the new Dolphin executable.
  
  Furthermore, running two different versions of Dolphin (in particular, where one does not have this patch included) can result in bugs appearing when the setting is enabled, in particular, new tabs not opening as old instances will not recognise the DBus commands send to it. However, I see no reason why a user will have two different versions of Dolphin (apart from people like us :D).
  
  With setting off:
  	Application should behave as before.
  With setting on:
  	Open directories with the help of auxillary programs (i.e. a browser). The files/directories should appear in a new window if an instance does not exist. If one already does, then a new tab should be opened and activated in that instance and the window activated.
  	When a user chooses to "Open In New Window"/"Detach Tab" then the files/directories should be opened in a new window.

REPOSITORY
  R318 Dolphin

BRANCH
  DBusTabInstance

REVISION DETAIL
  https://phabricator.kde.org/D16648

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/dbusinterface.cpp
  src/dolphinmainwindow.cpp
  src/dolphinmainwindow.h
  src/dolphintabwidget.cpp
  src/global.cpp
  src/global.h
  src/main.cpp
  src/settings/dolphin_generalsettings.kcfg
  src/settings/startup/startupsettingspage.cpp
  src/settings/startup/startupsettingspage.h
  src/tests/dolphinmainwindowtest.cpp

To: feverfew
Cc: kfm-devel, alexde, sourabhboss, feverfew, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20181103/7a5a74f9/attachment.htm>