D12571: Modernize Settings window
Nathaniel Graham
noreply at phabricator.kde.org
Sat May 26 05:24:59 BST 2018
ngraham updated this revision to Diff 34903.
ngraham added a comment.
More changes from #VDG <https://phabricator.kde.org/tag/vdg/> ui review:
- Remove the "use default location" button; it's redundant since the window already has a button to reset to defaults
- Use a pretty inline `KMessageWidget` in case of an invalid path instead of a modal `KMessageBox` with a grammatically incorrect sentence
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12571?vs=34897&id=34903
BRANCH
no-more-group-boxes (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12571
AFFECTED FILES
src/settings/dolphinsettingsdialog.cpp
src/settings/general/behaviorsettingspage.cpp
src/settings/general/confirmationssettingspage.cpp
src/settings/general/statusbarsettingspage.cpp
src/settings/navigation/navigationsettingspage.cpp
src/settings/startup/startupsettingspage.cpp
src/settings/startup/startupsettingspage.h
src/settings/trash/trashsettingspage.cpp
src/settings/viewmodes/viewsettingstab.cpp
src/settings/viewmodes/viewsettingstab.h
To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180526/e4bde5c5/attachment.htm>
More information about the kfm-devel
mailing list