D12571: Modernize Settings window

Nathaniel Graham noreply at phabricator.kde.org
Fri May 25 00:06:56 BST 2018


ngraham added a comment.


  In D12571#267808 <https://phabricator.kde.org/D12571#267808>, @abetts wrote:
  
  > It looks good and according to the VDG direction. It does feel a bit cramped. Is the current window size absolute or dynamic? If it was absolute, we could make it bigger?
  
  
  The height adjusts; the width is currently hardcoded (material for another patch later). I could add a bit of internal padding between the interior edges of the content area and the controls. Here's an example with 18px (i.e `gridUnit`) margins:
  F5867320: 18px margins.png <https://phabricator.kde.org/F5867320>

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180524/d252be45/attachment.htm>


More information about the kfm-devel mailing list