D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

Nathaniel Graham noreply at phabricator.kde.org
Thu May 24 14:22:24 BST 2018


ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcmtrash.cpp:303
> There's no benefit in changing the initial parent of these.
> 
> It's all moot as QFormLayout::addItem takes ownership

Ah right, I think I wrote this before I found that out. In fact, you can omit the parent entirely, so I think I'll do that.

REPOSITORY
  R241 KIO

BRANCH
  clean-up-trash-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12986

To: ngraham, #dolphin, #frameworks, #vdg, davidedmundson
Cc: davidedmundson, abetts, rkflx, kfm-devel, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180524/bf0e36da/attachment.htm>


More information about the kfm-devel mailing list