D12795: Re-allow running Dolphin as the root user (but still not using sudo)

Martin Flöser noreply at phabricator.kde.org
Sun May 20 15:37:32 BST 2018


graesslin added inline comments.

INLINE COMMENTS

> main.cpp:47
> +    // Prohibit using sudo or kdesu (but allow using the root user directly)
>      if (getuid() == 0) {
> +        if (!qEnvironmentVariableIsEmpty("SUDO_USER")) {

what about:
su root
DISPLAY=:0 dolphin

why should that be allowed given that it has the same risk?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12795

To: ngraham, markg, elvisangelaccio, #dolphin
Cc: cfeck, elvisangelaccio, mmustac, Fuchs, markg, graesslin, nicolasfella, zzag, kfm-devel, emmanuelp, spoorun, navarromorales, isidorov, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180520/38e3e4de/attachment.htm>


More information about the kfm-devel mailing list