D12929: Remove main.cpp from dolphinstatic_SRCS

[Alexander Miller]

almiller created this revision.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
almiller requested review of this revision.

REVISION SUMMARY
  The file main.cpp is already in dolphin_SRCS and doesn't
  belong in dolphinstatic_SRCS.
  
  Normally the duplicate object is simply ignored, but with
  link time optimization (LTO), linking dolphin can fail.
  Apparently, the compiler tries to inline inline kdemain()
  in this case. That is undesirable anyway and it ultimately
  fails because the DBusInterface definition is not available:
  
  .../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()':
  <artificial>:(.text+0x2583): undefined reference to `vtable for DBusInterface'
  .../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()':
  <artificial>:(.text+0x5aa3): undefined reference to `vtable for DBusInterface'
  .../ccHEv6cl.ltrans0.ltrans.o: In function `kdemain':
  <artificial>:(.text+0x7686): undefined reference to `DBusInterface::DBusInterface()'
  <artificial>:(.text+0x7b64): undefined reference to `vtable for DBusInterface'
  collect2: error: ld returned 1 exit status
  
  See also https://bugs.gentoo.org/655710.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12929

AFFECTED FILES
  src/CMakeLists.txt

To: almiller
Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180516/4fb96468/attachment.htm>