D12605: added 'add_to_places' action to file menu and as a shortcut

[Mark Gaiser]

markg added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:1243
> +    addToPlaces->setText(i18nc("@action:inmenu Add current folder to places", "Add to Places"));
> +    actionCollection()->setDefaultShortcuts(addToPlaces, {Qt::CTRL + Qt::Key_D});
> +    connect(addToPlaces, &QAction::triggered, this, &DolphinMainWindow::addToPlaces);

Please do not use CTRL+D as key binding.
It already has a mix of things it does.

In Konsole: it closes the current tab
In Chrome: it adds the current page to your bookmarks

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12605

To: rpetrov, #dolphin, ngraham
Cc: markg, kfm-devel, ngraham, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180509/a59ae842/attachment.htm>