D12571: Remove all group boxes from settings window, and adjust UI accordingly

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D12571#255770 <https://phabricator.kde.org/D12571#255770>, @ngraham wrote:
  
  > I'm not trying to assassinate the group box, don't worry. :) It has its uses for sure. But in general we tend to overuse rather than underuse it.
  >
  > The practical issue with group boxes is that when they're contained within other grouping elements (like tabbed views) or contain list boxes, you very quickly get single-pixel-line-overload. There can easily be 3 or 4 or more vertical lines right next to each other and it just looks overwhelming, and distracts your visual focus away from the content.
  
  
  Is this really an issue though? I never even noticed that we have those 3 vertical lines in the General settings page.
  
  > Regarding the general design, as @abetts is fond of saying, there's no right or wrong in design, but it does evolve over time. My aim here is to align the Configure window's design with the way that KDE settings UI design in general is evolving. Take a look at the re-done KCMs recently, and in particular the FormLayout KCM template: it features centered UI controls and no group boxes, just like this patch. Here's the Launch Feedback KCM for example:
  
  I see a lot of empty space in that KCM. It might work for this specific case, since its checkboxes and radiobuttons have a very short text, but I'm not convinced we should do the same everywhere (you might need to show a much longer sentence after a checkbox).
  
  > Some KDE apps such as Gwenview already make use of this style for their own Configure windows:
  
  Gwenview has the same problem of floating checkboxes, caused by how it's misusing text+radiobuttons.
  
  Why is Gwenview doing this
  
    Some text: o First option
               o Second option
  
  instead of this?
  
    Some text:
       o First option
       o Second option
  
  The second pattern is what's in the radiobuttons HIG <https://community.kde.org/KDE_Visual_Design_Group/HIG/RadioButtons>, and in other apps such as the Ark general settings:
  
  F5835555: Screenshot_20180505_191125.png <https://phabricator.kde.org/F5835555>

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: elvisangelaccio, abetts
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180505/1bb87dd5/attachment.htm>