D11816: Split Image Size into Width/Height

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileitemmodel.cpp:1856-1859
>          // Alway use a natural comparing to interpret the numbers of a string like
>          // "1600 x 1200" for having a correct sorting.
> -        result = collator.compare(a->values.value("imageSize").toString(),
> -                                  b->values.value("imageSize").toString());
> +        result = collator.compare(a->values.value(roleForType(m_sortRole)).toString(),
> +                                  b->values.value(roleForType(m_sortRole)).toString());

Since we are splitting into width/height, we can just convert them to int, no?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11816

To: xyquadrat, #dolphin, elvisangelaccio
Cc: elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180331/381d071e/attachment.htm>