D11650: Fix alignment of icons in Places panel and Compact view mode

Scott Harvey noreply at phabricator.kde.org
Wed Mar 28 10:09:40 BST 2018


sharvey added a comment.


  In D11650#235794 <https://phabricator.kde.org/D11650#235794>, @zzag wrote:
  
  > In D11650#235747 <https://phabricator.kde.org/D11650#235747>, @sharvey wrote:
  >
  > > @zzag : That's a nice calculation. I patched it in temporarily and had a look. I get a value of 0.5 for `midlineShift` (Noto Sans 11), so we're once again looking at fractions of pixels(!)
  >
  >
  > What's your screen scale value?
  >
  > Also, I could screw up somewhere while I was simplifying code. IIRC the shift should be 1(or not?) when screen scale is equal to 1.
  
  
  Screen scale is 1.0 - it's probably a fluke due to running in a virtual machine.
  
  I've added in your adjustment and updated the patch. We'll let @ngraham give us his opinion. I think it looks fine as well, but we'll let him give the final answer.

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D11650

REVISION DETAIL
  https://phabricator.kde.org/D11650

To: sharvey, #dolphin, ngraham, cfeck
Cc: zzag, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180328/63099fc7/attachment.htm>


More information about the kfm-devel mailing list