D11481: [KItemListView] Check if KItemListStyleOption actually changed before emitting a change

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Mar 28 08:55:07 BST 2018


broulik added a comment.


    void KFileItemListView::onStyleOptionChanged(const KItemListStyleOption& current, const KItemListStyleOption& previous)
    {
        KStandardItemListView::onStyleOptionChanged(current, previous);
        triggerIconSizeUpdate();
    }
  
  This is executed when the style option changes, `triggerIconSizeUpdate()` starts a `m_updateIconSizeTimer` of 300ms and during that time preview generation is paused as to not repeatedly recreate icons when you e.g. change the icon size with a slider. However, this would also needlessly delay icon generation when moving between folders as without this patch it always signals a style option change when moving between folders even if both folders use the same icon size and view mode.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11481

To: broulik, #dolphin, elvisangelaccio
Cc: markg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180328/fba46f7c/attachment.htm>


More information about the kfm-devel mailing list