D11650: Fix alignment of icons in Places panel and Compact view mode
Scott Harvey
noreply at phabricator.kde.org
Tue Mar 27 22:33:38 BST 2018
sharvey added a comment.
In D11650#235654 <https://phabricator.kde.org/D11650#235654>, @zzag wrote:
> It's because action icons have inner padding.
Well that's not helpful (in this case)!
> As you see, Noto Sans' midline is slightly lower than text rect's midline so that's why text feels bottom-aligned, I guess. It doesn't have anything to do with rounding errors, etc.
I, too, love typography. What did you use to generate that sample?
Between padded icons and questionable midlines... no wonder this "simple" fix became so complicated.
REPOSITORY
R318 Dolphin
BRANCH
arcpatch-D11650
REVISION DETAIL
https://phabricator.kde.org/D11650
To: sharvey, #dolphin, ngraham, cfeck
Cc: zzag, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180327/7b633291/attachment.htm>
More information about the kfm-devel
mailing list