D11650: Fix alignment of icons in Places panel and Compact view mode

Scott Harvey noreply at phabricator.kde.org
Tue Mar 27 19:37:41 BST 2018


sharvey added inline comments.

INLINE COMMENTS

> zzag wrote in kstandarditemlistwidget.cpp:1027
> Please notice, you're doing an integer division. Cast m_scaledPixmapSize.height() to qreal or divide by 2.0.
> 
> (it seems like the code above does the same too)

I'm pretty sure my decimal places got lost during multiple revisions, recompilations, and re-tests, of which there have been MANY. I corrected it, along with the others above. Thanks for catching it.

REPOSITORY
  R318 Dolphin

BRANCH
  align-compact-icons

REVISION DETAIL
  https://phabricator.kde.org/D11650

To: sharvey, #dolphin, ngraham, cfeck
Cc: zzag, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180327/f575bee1/attachment.htm>


More information about the kfm-devel mailing list