D11733: Allow opening items from the open/save dialogs

Nathaniel Graham noreply at phabricator.kde.org
Tue Mar 27 00:29:54 BST 2018


ngraham created this revision.
ngraham added reviewers: Dolphin, Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch adds an Open menu item to the open/save dialogs' context menu.
  
  FEATURE: 392329

TEST PLAN
  I am not 100% on this feature. The bug report requested the feature for previewing files, but maybe the issue is discoverability of the inline and aside previews? This patch is offered as much for discussion as to implement the feature and close the bug, but it does work:
  
  - Right-click on a file > Open -> Opens the file in the default app for it
  - Right-click on a folder > Open -> Opens the folder
  - Right-click on the background > Open -> Opens the parent folder
  - One issue is that if the item opens in the very same app that invoked the open/save dialog, the resulting window can't actually be interacted with or closed because the dialog is modal.
  
  [image goes here]

REPOSITORY
  R241 KIO

BRANCH
  add-open-to-context-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11733

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h

To: ngraham, #dolphin, #frameworks
Cc: michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180326/1607eabf/attachment.htm>


More information about the kfm-devel mailing list