D11204: Support NTFS hidden files

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> file_unix.cpp:40
>  #include <errno.h>
> +#include <sys/xattr.h>
>  #include <utime.h>

This unconditional include sadly breaks the build at least on FreeBSD (see https://build.kde.org/view/Frameworks/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/164/console ) and other systems where this header is not part of the libc (?) headers.

So this needs to get some condition checking before using it. Compare other code doing that:
https://lxr.kde.org/search?_filestring=&_string=xattr.h&_casesensitive=1

While the xattr.h is already checked for in KIO in the FindACL.cmake file, an explicite check like

  check_include_files(sys/xattr.h HAVE_SYS_XATTR_H)

and passing HAVE_SYS_XATTR_H via config-kioslave-file.h.cmake into file_unix.cpp and checking the condition additionally to or instead of Q_OS_LINUX for the new code should solve this issue properly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, dfaure
Cc: kossebau, dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180326/f02f459d/attachment.htm>