D11204: Support NTFS hidden files

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.

INLINE COMMENTS

> file_unix.cpp:415
> +#ifdef Q_OS_LINUX
> +bool isNtfsHidden(const QString &filename)
> +{

static

> file_unix.cpp:422
> +    }
> +    constexpr size_t xattr_size = 1024;
> +    char strAttr[xattr_size];

Doesn't this need to be static, for the next line to be standards compliant? Not 100% sure.

> file_unix.cpp:424
> +    char strAttr[xattr_size];
> +    length = getxattr(filename.toLocal8Bit().data(), attrName, strAttr, xattr_size);
> +    if (length <= 0) {

but filename.toLocal8Bit() in a local QByteArray so you don't do this conversion twice.
And in fact this should use QFile::encodeName() instead of toLocal8Bit().

> file_unix.cpp:431
> +    static const auto digits = "0123456789abcdef";
> +    auto hexAttr = new char[length * 2 + 4];
> +    char *c = strAttr, *e = hexAttr;

QVarLengthArray might be useful here to avoid an allocation every time

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11204

To: rominf, #dolphin, #frameworks, markg, dfaure
Cc: dfaure, markg, elvisangelaccio, ltoscano, anthonyfieroni, broulik, #frameworks, #dolphin, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180324/77a2f7ef/attachment.htm>