D11650: Fix alignment of icons in Places panel and Compact view mode

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kstandarditemlistwidget.cpp:1021
> +        } else {
> +            // Center horizontally and vertically within the icon-area
> +            const TextInfo* textInfo = m_textInfo.value("text");

This comment probably becomes obsolete after this patch?

> kstandarditemlistwidget.cpp:1023
> +            const TextInfo* textInfo = m_textInfo.value("text");
> +            QPointF textRectCenter = m_textRect.center();
> +            m_pixmapPos.setX(textInfo->pos.x() - 2 * padding

Should be `const`

> kstandarditemlistwidget.cpp:1028
> +            // Always derive icon's horizontal center from the center of the text frame
> +            m_pixmapPos.setY(textRectCenter.y() - (m_scaledPixmapSize.height() / 2 ));
> +        }

What about `padding`? Is there a reason we are removing it?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11650

To: sharvey, #dolphin, ngraham, cfeck
Cc: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180324/010d53a4/attachment.htm>