D11650: Fix alignment of icons in Places panel and Compact view mode
Scott Harvey
noreply at phabricator.kde.org
Sat Mar 24 16:28:14 GMT 2018
sharvey created this revision.
Restricted Application added a subscriber: Dolphin.
sharvey requested review of this revision.
REVISION SUMMARY
Adjust calculation of icon pixmap Y value; now based off center of text label bounding rectangle. Previously, icons appeared top-aligned when text size was larger than icon size. See before and after screenshots.
BUG: 390771
TEST PLAN
- Compile Dolphin with patch
- Increase system font size by several points (i.e. 15pt)
- Check that Places panel icons remain centered with the text label
- Select Compact View mode
- Adjust icon size slider to minimum
- Ensure that icons also remain centered in file listing
- Check several combinations of icon size & font size to ensure centering is consistent
REPOSITORY
R318 Dolphin
BRANCH
align-compact-icons
REVISION DETAIL
https://phabricator.kde.org/D11650
AFFECTED FILES
src/kitemviews/kstandarditemlistwidget.cpp
To: sharvey
Cc: #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180324/9c397511/attachment.htm>
More information about the kfm-devel
mailing list