D11540: [DolphinContextMenu] Fix excluding ourself from Open With menu

[Nathaniel Graham]

ngraham added a comment.


  In D11540#231118 <https://phabricator.kde.org/D11540#231118>, @rkflx wrote:
  
  > In D11540#230872 <https://phabricator.kde.org/D11540#230872>, @ngraham wrote:
  >
  > > In D11540#230829 <https://phabricator.kde.org/D11540#230829>, @broulik wrote:
  > >
  > > > That is by design in `KFileItemActions` and would need to be changed there, not sure we should, though. But that is unrelated to this fix which clearly fixes a bug.
  > >
  > >
  > > I've got some ideas for ways to improve the usability here and may submit some patches today or tomorrow. This can land, thanks again!
  >
  >
  > @ngraham Are you sure there's a bug? It's always been this way (← bad reason), and it makes sense: If the list is too long there will be a submenu, and for only a few items the submenu is overkill and a flattened list is easier (← good reason ;)
  >
  > Nevertheless, I'm curious about your idea (as long as it won't result in another KMoreTools-style UI).
  
  
  Oh no, not at all. I'm still mulling it over, but I'll have a patch available soon enough for critique and discussion.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11540

To: broulik, #dolphin, ngraham
Cc: rkflx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180322/d857343e/attachment.htm>