D11324: Select files instead of opening them when trying to open a QUrl as a directory when in fact it is a file.

[Emirald Mateli]

emateli added a comment.


  In D11324#228467 <https://phabricator.kde.org/D11324#228467>, @elvisangelaccio wrote:
  
  > The feature is that you can open a file by typing its name in the url navigator, see e9463ffe2ac11019 <https://phabricator.kde.org/R318:e9463ffe2ac110193cac4c25fcba887249f52b3c>.
  
  
  That does sound like a feature we'd be breaking which I was unaware of.
  
  > @emateli Sounds like plasma should pass the `--select` paramater then?
  
  I'm not sure why the shell should be aware on how to launch Dolphin with special parameters when the parameter is a file or a directory. The way it is now is consistent with all DE that i've used so far.
  
  With that in mind however I'd like to propose the following:
  
  - We keep and fix the navigation from the KUrlNavigator. If a directory is typed in then the view will change, otherwise if it's a file, the application will launch it while remaining in the same directory. This IMO should work only for local files (and it's also much easier to implement, at that). If you type some ftp url it should not execute it (but with the current patch it will select it)
  - We change the behaviour of the parameter to what the patch proposes. No file execition when launched from the shell but rather selection.
  - When requesting to browse a file which is an archive it will be opened inside Dolphin only when the appropriate configuration is active, otherwise it will fallback to the default behaviour(run if via kurlnavigator) otherwise select.  (This one I'm less convinced overall, but seems like a more consistent behaviour given that the BrowseThroughArchives setting exists)
  
  Thoughts?

REPOSITORY
  R318 Dolphin

BRANCH
  select-open-file

REVISION DETAIL
  https://phabricator.kde.org/D11324

To: emateli, rkflx, ngraham, dfaure, elvisangelaccio, #dolphin
Cc: michaelh, broulik, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180318/90561cbe/attachment.htm>