D11382: Add an option to show tabs from last time when Dolphin starts

[Kai Uwe Broulik]

broulik added a comment.


  How does that behave when I start Dolphin a second time? I'm a person that usually has 5 Dolphin windows open with tons of tabs inside of them.

INLINE COMMENTS

> dolphinmainwindow.cpp:186
> +        QTimer::singleShot(0, [this]() {
> +            KConfigGroup windowState{KSharedConfig::openConfig(QStringLiteral("dolphinrc")), "WindowState"};
> +            readProperties(windowState);

Instead of hardcoding those settings everywhere, please use KConfigXt (the `kcfg` files you can see for other places in Dolphin), like `GeneralSettings`

> startupsettingspage.cpp:95
>  
> +    m_rememberOpenedTabs = new QCheckBox(i18nc("@option:check Startup Settings", "Show tabs from last time"), vBox);
> +    vBoxLayout->addWidget(m_rememberOpenedTabs);

This wording could be improved (can't think of one right now)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11382

To: rominf, #dolphin
Cc: broulik, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180316/b73e981d/attachment.htm>