D10990: Add "Show Target" into symlink context menu and file menu

Elvis Angelaccio noreply at phabricator.kde.org
Thu Mar 15 20:57:29 GMT 2018


elvisangelaccio added inline comments.

INLINE COMMENTS

> rominf wrote in dolphinmainwindow.cpp:1396-1399
> Note `=` after `showOriginal`. It's aligned to the `=` after `deleteWithTrashShortcut`. Other actions should be formatted the same way. It's previous commiter fault that he didn't format the things well.
> What is the purpose to revert formatting if it's already in the repository?
> OK, now I understand that I don't have to commit formatting changes alongside the main code. Should I do separate patch like "And now format the code I pushed before"?

Fine, let's forget about this. But next time remember that commits should be atomic (= no unrelated stuff).

> dolphinmainwindow.h:521
> +
> +    void showTarget();
>  };

Please move it to the `private slots` section of the class.

> dolphinui.rc:2
>  <!DOCTYPE kpartgui SYSTEM "kpartgui.dtd">
>  <kpartgui name="dolphin" version="18">
>      <MenuBar>

This needs to be bumped again.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10990

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: rkflx, ngraham, elvisangelaccio, markg, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180315/423811d0/attachment.htm>


More information about the kfm-devel mailing list