D10990: Add "Open symlink destination folder" into symlink's context menu

Roman Inflianskas noreply at phabricator.kde.org
Thu Mar 15 11:22:26 GMT 2018


rominf added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:1219
> Why "Show Original"? What does original mean?
> 
> I'd have expected either "Show Destination" or "Show Target".

I'm for "Show Target" ("symlink target" is 5x times more popular than "symlink destination" in Google).
BTW, the author of "Show Original" was @ngraham.

> elvisangelaccio wrote in dolphinmainwindow.cpp:1396-1399
> Unrelated code style change. Please revert.

Note `=` after `showOriginal`. It's aligned to the `=` after `deleteWithTrashShortcut`. Other actions should be formatted the same way. It's previous commiter fault that he didn't format the things well.
What is the purpose to revert formatting if it's already in the repository?
OK, now I understand that I don't have to commit formatting changes alongside the main code. Should I do separate patch like "And now format the code I pushed before"?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10990

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: rkflx, ngraham, elvisangelaccio, markg, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180315/a55a96e1/attachment.htm>


More information about the kfm-devel mailing list