D11334: Disable Create New menu and button when Trash dir is active

Nathaniel Graham noreply at phabricator.kde.org
Wed Mar 14 20:19:15 GMT 2018


ngraham added inline comments.

INLINE COMMENTS

> dolphinmainwindow.cpp:1369
>  {
> +    m_newFileMenu->menu()->setEnabled(m_activeViewContainer->url().scheme() != QLatin1String("trash"));
>      const KFileItemList list = m_activeViewContainer->view()->selectedItems();

Is this needed, given the writability check in `dolphinviewactionhandler.cpp`? And if it is, should it be same same writability check here, instead of a string comparison for "trash"?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11334

To: rominf, #dolphin
Cc: ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180314/9e82c6f9/attachment.htm>


More information about the kfm-devel mailing list