D10804: Show "Empty Trash" button inside trash directory

Nathaniel Graham noreply at phabricator.kde.org
Wed Mar 14 18:38:29 GMT 2018


ngraham accepted this revision.
ngraham added a comment.


  In D10804#225439 <https://phabricator.kde.org/D10804#225439>, @rominf wrote:
  
  > In D10804#223457 <https://phabricator.kde.org/D10804#223457>, @markg wrote:
  >
  > > In D10804#223410 <https://phabricator.kde.org/D10804#223410>, @rominf wrote:
  > >
  > > > In D10804#223394 <https://phabricator.kde.org/D10804#223394>, @markg wrote:
  > > >
  > > > > @rominf if i restore from within the trash (trash is empty after restoring), the trash icon in the places menu and the "Empty Trash" button both stay active.
  > > > >  Could you take a look at that?
  > > >
  > > >
  > > > It works for me. Can you check it again (I rebased this on master).
  > >
  > >
  > > Just done that, same as before.
  > >  The icon only updates if i click on the trash again.
  >
  >
  > Still cannot reproduce. @elvisangelaccio, @ngraham Can you ckeck it?
  
  
  With a clean build, works fine for me.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, ngraham, markg, elvisangelaccio
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180314/9ca452c4/attachment.htm>


More information about the kfm-devel mailing list