D11324: Select files instead of opening them when trying to open a QUrl as a directory when in fact it is a file.

[Emirald Mateli]

emateli created this revision.
emateli added reviewers: rkflx, ngraham, dfaure, elvisangelaccio.
Restricted Application added a subscriber: Dolphin.
emateli requested review of this revision.

REVISION SUMMARY
  When dolphin is executed with a parameter which happens to be a file, it will open a non existing directory and execute the file. This 
  patch changes the behaviour to instead select the file and open its parent directory.
  
  This can occurr if you intentionally launch Dolphin with a file name as a parameter (without specifying `--select`), or drag and dropping a 
  file to its task bar icon. This change is true for all files except archives, since due to a prior 
  patch(https://git.reviewboard.kde.org/r/119877/) all archives will be openened in a new tab.
  
  Given that, I also propose a second change: To browse archives as a directory only when the appropriate setting("Open Archives as folders") 
  is enabled.

TEST PLAN
  - Launch dolphin with a file as parameter or by dropping an icon to its task icon.

REPOSITORY
  R318 Dolphin

BRANCH
  select-open-file

REVISION DETAIL
  https://phabricator.kde.org/D11324

AFFECTED FILES
  src/dolphinviewcontainer.cpp

To: emateli, rkflx, ngraham, dfaure, elvisangelaccio
Cc: #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180314/f832b5c9/attachment.htm>