D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Henrik Fehlauer]

rkflx added a comment.


  In D10960#225162 <https://phabricator.kde.org/D10960#225162>, @ngraham wrote:
  
  > For the confirmation dialog added here, I'm unsure whether we should follow the advice of our inline conversation and make the Quit button be default. Depending on what's running in the Terminal panel, killing it could be quite destructive. But I won't block on that, and will accept whatever #dolphin <https://phabricator.kde.org/tag/dolphin/> maintainers decide.
  
  
  Huh? The inline conversation started with the unrelated change to the tab handling, where Cancel is not the right default. Applying what we learned there to the terminal panel handling (i.e. you could have started Kate, which would be killed without a chance to save), defaulting to Cancel in this Diff makes sense to me.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180314/4bcf4b33/attachment.htm>