D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> rkflx wrote in dolphinmainwindow.cpp:401
> > Do you agree with the change by itself?
> 
> That's for #dolphin <https://phabricator.kde.org/tag/dolphin/> to decide. Personally I think this should be a coordinated effort, see T7022 <https://phabricator.kde.org/T7022> for a longer discussion. I did not think this through yet, but for the moment I'm not too fond of making Cancel default.

Usability-wise, Cancel is the appropriate default. The default button should never cause you to lose work or state. If tab state is considered unimportant, then we shouldn't have a "close multiple tabs" confirmation in the first place. But if we do have one, then the safe/non-destructive choice must be default.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180313/fa8690cf/attachment.htm>