D10960: Ask for confirmation when Closing Dolphin windows with a terminal panel running a program

Roman Inflianskas noreply at phabricator.kde.org
Tue Mar 13 17:35:16 GMT 2018


rominf added inline comments.

INLINE COMMENTS

> rkflx wrote in dolphinmainwindow.cpp:401
> Unrelated change?
> 
> (At least in Okular there were huge discussions on the type of icon, and I think it's bad form if you just sneak in such changes in this patch…)

I thought that making the separate patch because of one line of code is too much. Sorry. Do you agree with the change by itself? Should I do it in the separate patch?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10960

To: rominf, #dolphin, ngraham, elvisangelaccio
Cc: elvisangelaccio, markg, ngraham, rkflx, broulik, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180313/911cd916/attachment.htm>


More information about the kfm-devel mailing list