D11283: Introduce singleton for KFilePlacesModel

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Dolphin, elvisangelaccio, davidedmundson, hein.
broulik requested review of this revision.

REVISION SUMMARY
  There are various places where Dolphin created a new `KFilePlacesModel` which would then query all storage devices and do other expensive work.

TEST PLAN
  It showed up as 37% cost on startup before, now it's 21%
  
  - Verified that only one instance is created and devices are only queried once.
  - Verified that places selector in URL bar still works
  - Verified that devices are still shown in sidebar
  - Adding places still works and is persisted between starts
  - Title bar still shows nice place names, e.g. "Home" instead of "username"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11283

AFFECTED FILES
  src/CMakeLists.txt
  src/dolphinmainwindow.cpp
  src/dolphinplacesmodelsingleton.cpp
  src/dolphinplacesmodelsingleton.h
  src/dolphinviewcontainer.cpp
  src/panels/places/placesitemmodel.cpp
  src/panels/places/placesitemmodel.h

To: broulik, #dolphin, elvisangelaccio, davidedmundson, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180313/2ae36fb4/attachment.htm>