D10804: Show "Empty Trash" button inside trash directory

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  I just tried it, works neatly.
  It also looks kinda fancy (even though it was not my first choice of having it next to the urlbar, it looks nice)
  
  It's a +1 from me after these 2 changes.
  @rkflx and @elvisangelaccio, you both had requested changes. Could you see if those are fulfilled?

INLINE COMMENTS

> dolphinviewcontainer.cpp:95
> +    m_emptyTrashButton->setFlat(true);
> +    connect(m_emptyTrashButton, &QPushButton::clicked, [this]() { Trash::instance().empty(this); });
> +    connect(&Trash::instance(), &Trash::emptinessChanged, m_emptyTrashButton, &QPushButton::setDisabled);

Trash::instance().empty(this); -> Trash::empty(this);

> dolphinviewcontainer.cpp:97
> +    connect(&Trash::instance(), &Trash::emptinessChanged, m_emptyTrashButton, &QPushButton::setDisabled);
> +    m_emptyTrashButton->setDisabled(Trash::instance().isEmpty());
> +    m_emptyTrashButton->hide();

Trash::instance().isEmpty() -> Trash::isEmpty()

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx, markg, elvisangelaccio
Cc: markg, emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180311/0091cc75/attachment.htm>