D11012: Add Trash (empty, isEmpty, emptinessChanged)

[Roman Inflianskas]

rominf added a comment.


  In D11012#222883 <https://phabricator.kde.org/D11012#222883>, @markg wrote:
  
  > I think it gets complicated now.
  >  This patch and D11216 <https://phabricator.kde.org/D11216> are now both not correct anymore (they are both the same, both do too much).
  >
  > Reduce this patch to just the Trash addition. Just the refactoring that is needed for that.
  >  So no icon changes in here.
  
  
  It's already true. If you are talking about the code that updates the icon with the notification signal, it's the part of refactoring. No logic changes involved.
  
  > Change D11216 <https://phabricator.kde.org/D11216> to **only** show the icon changes needed.
  
  I will, if this patch will be accepted. Refactoring is required to fix this bug, that's why I made this patch to a parent of D11216 <https://phabricator.kde.org/D11216>. So, first accept this patch, then D11216 <https://phabricator.kde.org/D11216>.
  
  Is there the way to rebase the patch on the patch that is not accepted yet? I mean on the left side of the patch D11216 <https://phabricator.kde.org/D11216> I see the code from the patch D11012 <https://phabricator.kde.org/D11012> (but not from `origin/master`), on the right side I see lines from the patch D11216 <https://phabricator.kde.org/D11216>.
  
  > Don't give up now, you're nearly there :)
  
  I don't.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11012

To: rominf, elvisangelaccio, markg, ngraham
Cc: ngraham, markg, rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180311/27c26ab8/attachment.htm>