D11012: Add Trash (empty, isEmpty, emptinessChanged)

Nathaniel Graham noreply at phabricator.kde.org
Sat Mar 10 15:09:45 GMT 2018


ngraham accepted this revision as: ngraham.
ngraham added a comment.


  Verified that this fixes the bug with the following cases:
  
  - One  file, folder, or link in trash -> Restore -> icon updated correctly
  - Mixed group of files, folders, and links in trash -> Select all -> Restore -> icon updated correctly
  - Mixed group of files, folders, and links in trash -> Select one -> Restore -> icon correctly not updated
  - Mixed group of files, folders, and links in trash -> Restore them one at a time -> icon correctly updated after last item restored
  
  Approved from the functionality and "works as advertised" department. Wait for the final code review by the Dolphin maintainers before pushing, please!

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11012

To: rominf, #dolphin, elvisangelaccio, #kde_applications, markg, ngraham
Cc: ngraham, markg, rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180310/4c2fbe3a/attachment.htm>


More information about the kfm-devel mailing list