D11012: Add Trash (empty, isEmpty, emptinessChanged)

[Mark Gaiser]

markg added a comment.


  In D11012#222620 <https://phabricator.kde.org/D11012#222620>, @rkflx wrote:
  
  > In D11012#222615 <https://phabricator.kde.org/D11012#222615>, @markg wrote:
  >
  > > I think that's about it though. I have no further requests, the code looks OK to me (i did not test it).
  >
  >
  > Uh oh, testing is sometimes kinda important ;)
  >
  > > After this last comment it's a +1 from me.
  >
  > Note that you can "resign" if you don't want to "accept" after "requesting changes", so `arc land` won't block.
  >
  > > I do prefer if someone else also gives a +1 before you push it. @rkflx perhaps?
  >
  > Sorry, I'm currently not available for in-depth code review in Dolphin, only some random UI comments in-between…
  
  
  Right, then i will test more thoroughly.
  I don't want to resign, i want to give this a +1. When it's ready that is :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11012

To: rominf, #dolphin, elvisangelaccio, #kde_applications, markg
Cc: markg, rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180310/13c542d4/attachment.htm>