D11118: Show a message if Konsole part is not installed

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> terminalpanel.cpp:36
> +#include <QAction>
> +#include <QApplication>
> +#include <QDesktopServices>

Are these all really necessary to this patch? I thought we already fixed the #includes before?

> terminalpanel.cpp:171
> +            if (!m_isKonsoleInstalledTimer->isActive()) {
> +                constexpr auto isKonsoleInstalledPoolingTime = 1000;
> +                m_isKonsoleInstalledTimer->start(isKonsoleInstalledPoolingTime);

"Polling"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11118

To: rominf, #dolphin, ngraham, progwolff
Cc: rkflx, ngraham, elvisangelaccio, broulik, progwolff, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180309/101fb75e/attachment.htm>