D11135: [WIP] Scale font while zooming

[Henrik Fehlauer]

rkflx added a comment.


  @ngraham What you are essentially saying is that you find the font size in Gwenview's Browse mode (which shows exactly those "large" type of items like in Dolphin, i.e. thumbnails) too small, and even if the user set it to a normal size you would just increase it a bit, making it look inconsistent and frustrating the user.
  
  We can already set the icon size as well as the text size. What you are doing here (under the name of "increase the text size") is to combine both into a dynamic slider. Would you also suggest to increase the size of all UI elements when someone maximizes a window? Or attach a slider to the menubar so user's can quickly increase that size?
  
  This is not a zoom slider like on a web page, where you temporarily increase the size. The slider is used to permanently select a size of the icons/previews, and if there is no way to combine that setting with having a normal/permanent text size, that's bad. Where do you make the cut for turning off the feature? For 128px? For 64px? What about HiDPI, or custom default font sizes? I don't think your plan will work, and it's better to have it looking a bit odd like in your screenshot, than to create problems in all other cases.
  
  > I.e. if the user configured to use font size 14, then we should scale it to 21 (but not 15) for 256pt icons.
  
  If I configure a size for text and another size for icons, I want to get exactly that, and not something different. (Also note that if Use common properties for all folders is selected, the slider and the config entry for the default icon size are linked together.)
  
  ---
  
  Anyway that's just my take on it, better ask more of #Dolphin <https://phabricator.kde.org/tag/dolphin/>'s maintainers about it before putting too much work into a patch.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11135

To: rominf, #dolphin, ngraham
Cc: rkflx, ngraham, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180308/3580c3b6/attachment.htm>