D11118: Show a message if Konsole part is not installed
Roman Inflianskas
noreply at phabricator.kde.org
Thu Mar 8 18:40:20 GMT 2018
rominf added a comment.
In D11118#221449 <https://phabricator.kde.org/D11118#221449>, @ngraham wrote:
> Found a bug: If you click the X button to dismiss the message, then close and re-open the terminal panel, it doesn't show up again.
Fixed.
> I have some UI suggestions:
>
> - Don't even try to open the terminal panel, and instead show the KMessageWidget at the top of the main view, like other KMessageWidgets in Dolphin.
I do not agree. My variant approximately shows how the things should look like after Konsole installation.
> - Since Dolphin has to be restarted after Konsole is installed...
No, it has not. Just reopen panel, that's it.
I think that this patch is good enough for a quite rare problem, let's ship it!
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D11118
To: rominf, #dolphin
Cc: ngraham, elvisangelaccio, broulik, progwolff, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180308/9a81343c/attachment.htm>
More information about the kfm-devel
mailing list