D10990: Add "Open symlink destination folder" into symlink's context menu
Roman Inflianskas
noreply at phabricator.kde.org
Wed Mar 7 09:57:28 GMT 2018
rominf added a comment.
In D10990#220215 <https://phabricator.kde.org/D10990#220215>, @ngraham wrote:
> In D10990#220203 <https://phabricator.kde.org/D10990#220203>, @rominf wrote:
>
> > In D10990#220200 <https://phabricator.kde.org/D10990#220200>, @ngraham wrote:
> >
> > > So what do you think about adding Show Original into the File menu when a shortcut is selected?
> >
> >
> > I'm positive about this. But I think this should be done after unifying file menu and context menu (`Compress`, `Actions`, etc. is not shown in the file menu).
>
>
> Why not do it now? We're already touching this code, might as well do the right thing here to set a good example. If we don't, we're just making that problem worse and giving ourselves more work later, no?
I don't understand the logic supporting main menus: `Rename`, `Move to Trash`, `Delete` items are located in `File` menu, while `Cut`, `Copy`, `Paste` are located in `Edit` menu; `New Tab` is in the `File` menu, while `Recently closed tabs` is in the `Go` menu. I think this should be refactored. On the other hand, menu is not shown be default. Is it worth to have it, especially in this state?
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D10990
To: rominf, #dolphin, ngraham
Cc: rkflx, ngraham, elvisangelaccio, markg, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180307/0c9da103/attachment.htm>
More information about the kfm-devel
mailing list