D11022: Resize the "normal" folder icons

Julian Schraner noreply at phabricator.kde.org
Tue Mar 6 17:31:01 GMT 2018


xyquadrat added inline comments.

INLINE COMMENTS

> broulik wrote in informationpanelcontent.cpp:321
> Where does that magic number 12 come from?

This is the "bad" part of this patch... I took the number from `adjustWidgetSizes()`, where the width is defined as `const int maxWidth = width - style()->layoutSpacing(QSizePolicy::DefaultType, QSizePolicy::DefaultType, Qt::Horizontal) * 4;`. I found out that this corresponds to 12, because simply subtracting the `layoutSpacing()` from `parentWidget()->width()` did not work.

I need to change this (I know that simply hard-coding values is bad practice) but I couldn't figure out how.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11022

To: xyquadrat, #dolphin
Cc: ngraham, broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180306/6f02e5a2/attachment.htm>


More information about the kfm-devel mailing list