D11012: Add Trash (empty, isEmpty, emptinessChanged)

[Mark Gaiser]

markg requested changes to this revision.
markg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dolphinviewcontainer.cpp:39
>  #include <KRun>
> +#include <KRun>
>  #include <KShell>

This one is redundant.

> placesitem.h:98
>       */
> -    void onTrashDirListerCompleted();
> +    void onTrashEmptinessChanged();
>  

Where is the function body? It's not in placesitem.cpp.

> placesitem.h:118
>      friend class PlacesItemSignalHandler; // Calls onAccessibilityChanged()
> +    void onTrashEmptinessChanged(bool isTrashEmpty);
>  };

Where is the function body? It's not in placesitem.cpp.
Also, why here? move it up ~20 lines next to the other - also private - function.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11012

To: rominf, #dolphin, elvisangelaccio, #kde_applications, markg
Cc: markg, rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180305/1e6e5bd2/attachment.htm>