D10985: Remove unused #include

Mark Gaiser noreply at phabricator.kde.org
Sun Mar 4 15:04:12 GMT 2018


markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Now it makes more sense.
  Careful with arc ;)
  
  I see what you did in this change, it does make sense but is becoming difficult te review as a consequence. As now it's difficult to see which includes are re-organizes, which are removed and which are perhaps both...
  It does look a lot more organized now :)
  I looked through all of it and it all seems fine to me.
  
  I'd say: ship it! But keep it at this with the include refactoring please.
  Note: while you're at it, all the kitemviews/... includes should be within quotes (it's locally to dolphin, it's not an external library). You've changed a couple to quotes (good!) but there are quite a few more with < and >.
  I didn't mention it in the specific files as it really is fine with me as is, but if you //want// to change it, feel free :)

REPOSITORY
  R318 Dolphin

BRANCH
  remove-unused-include

REVISION DETAIL
  https://phabricator.kde.org/D10985

To: rominf, #dolphin, elvisangelaccio, markg
Cc: bcooksley, markg, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180304/ec1e0804/attachment.htm>


More information about the kfm-devel mailing list