D11012: Add Trash (empty, isEmpty, emptinessChanged)

Henrik Fehlauer noreply at phabricator.kde.org
Sun Mar 4 09:07:54 GMT 2018


rkflx added a comment.


  Thanks for making it easier to review and the Git history tidier ;)
  
  In D10804#217489 <https://phabricator.kde.org/D10804#217489>, @elvisangelaccio wrote:
  
  > I like the UI now, but it's kinda hard to review the code. Can you please split this patch into more commits? At least one for the bugfix and one for the new feature.
  
  
  @rominf Does this patch now contain the bugfix? If so, you could split the commit message too. In any case, add something to the summary and the test plan.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11012

To: rominf, #dolphin, elvisangelaccio, #kde_applications
Cc: rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180304/ad5b38a3/attachment.htm>


More information about the kfm-devel mailing list