D10995: Fix some compile warnings

Henrik Fehlauer noreply at phabricator.kde.org
Sun Mar 4 07:35:44 GMT 2018


rkflx reopened this revision.
rkflx added a comment.
This revision is now accepted and ready to land.


  If you request review from #dolphin <https://phabricator.kde.org/tag/dolphin/> and @elvisangelaccio comments, please wait for his "ship it".

INLINE COMMENTS

> dolphintabwidget.cpp:94-97
> +#pragma GCC diagnostic push
> +#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>              tabPageAt(i)->restoreStateV1(state);
> +#pragma GCC diagnostic pop

Was this part of the original Diff people reviewed?

> phononwidget.cpp:26-29
> +#pragma GCC diagnostic push                          // Phonon doesn't use C++11 compiler by default, so override
> +#pragma GCC diagnostic ignored "-Wsuggest-override"  // specifier is not available. Remove this pragmas after fixing it.
>  #include <Phonon/VideoWidget>
> +#pragma GCC diagnostic pop

Was this part of the original Diff people reviewed?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10995

To: rominf, #dolphin, markg
Cc: rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180304/75bbaefa/attachment.htm>


More information about the kfm-devel mailing list