D10995: Fix some compile warnings

Roman Inflianskas noreply at phabricator.kde.org
Sun Mar 4 07:05:41 GMT 2018


rominf marked an inline comment as done.
rominf added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:414
> Don't we need a  `break` here?

Because:

- Do you want to close all tabs?
- Nope. Close please only the active one.
- OK. Closing it. Canceling quit. Ignoring the quit event.

> elvisangelaccio wrote in kitemlistcontroller.cpp:438-439
> Why this change?

GCC doesn't not produce warning about fall through if it captures a comment about "fall through". By some reason GCC didn't like previous comment. I just made him happy.

REPOSITORY
  R318 Dolphin

BRANCH
  fix-warnings

REVISION DETAIL
  https://phabricator.kde.org/D10995

To: rominf, #dolphin, markg
Cc: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180304/7d686ab2/attachment.htm>


More information about the kfm-devel mailing list